Require Ruby 3.2 and Rails 7.2 (oldest current supported versions) - #6412
Require Ruby 3.2 and Rails 7.2 (oldest current supported versions)#6412AlistairNorman wants to merge 2 commits into
Conversation
Rails 7.0 and 7.1 are out of support along with Ruby 3.1. Co-Authored-By: Jared Norman <jared@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Noah Silvera <noah@super.gd> Co-Authored-By: Sofia Besenski <sofia@super.gd>
github-actions
Bot
added
the
changelog:repository
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6412 +/- ##
=======================================
Coverage 89.50% 89.50%
=======================================
Files 981 981
Lines 20479 20479
=======================================
Hits 18329 18329
Misses 2150 2150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
changelog:solidus_api
The Solidus policy is for minor releases to support only up to the oldest maintained version of Ruby and Rails. Co-Authored-By: Jared Norman <jared@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Noah Silvera <noah@super.gd> Co-Authored-By: Sofia Besenski <sofia@super.gd>
3436694 to
2236a37
Compare
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Appreciate this, but let's split this up into two PRs for better discoverability in the changelog. Or rename the PR and just tell the truth. We should a least have two PRs for Rails and Ruby.
| end + ["app/assets/builds/solidus_admin/tailwind.css"] | ||
|
|
||
| s.required_ruby_version = '>= 3.1.0' | ||
| s.required_ruby_version = '>= 3.2.0' |
There was a problem hiding this comment.
From your PR title you just removed it from CI, but you also prevent running solidus on older Rubies with this change. Although I like the progressive nature of this, I think we should stop testing in one PR and then on another PR raise the minimum version. That way it will appear in the Changelog. A single commit in a PR does not end up on the Changleog.
There was a problem hiding this comment.
Good callout on the title. I think this belongs as one PR because we only want to remove versions from CI when we stop supporting them. That being said, you're right that the important thing to go in the changelog is that we changed the required version.
There was a problem hiding this comment.
I think this belongs as one PR because we only want to remove versions from CI when we stop supporting them
Stop supporting the Ruby version is the same as not testing it anymore. But also raising the minimum version means it cannot be used at all anymore, what is not the same as stop supporting (aka fixing issues) it.
But I am fine with doing the Ruby version bump in the same PR as the CI change, but I still want us to split out the Rails change from this PR for visibility in the changelog.
There was a problem hiding this comment.
I know the distinctions. Can you explain why two pull requests are more visible than one?
AlistairNorman
changed the title
5 participants
Summary
Rails 7.0 and 7.1 are out of support along with Ruby 3.1 so we don't need to be testing them. This will speed up CI a bit.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: